Ensure that Parallel Gateway waits for a token to arrive on each incoming flow before progressing#4183
Open
jguthrie100 wants to merge 2 commits intoflowable:mainfrom
Open
Conversation
…ming flow before progressing
Author
|
Fixes #4166 |
Contributor
|
This is not the right fix @jguthrie100. You cannot use historic data for determining what should be done in the runtime. This won't work if the history level is none, task or instance, since there won't be any historic activity instances created. As you have seen from the comment on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Parallel Gateway implementation doesn't follow the BPMN 2.0 spec.
This changes it so that it does, and that the parallel gateway waits for a token to arrive from each incoming flow, rather than just waiting for the same number of tokens as there are incoming flows.
Edit: just to point out that's it's not an AI solution either. It's a fully handwritten, hand tested solution!